Java frontend: record source locations of read static variables #5144
Conversation
smowton
requested review from
cesaro,
cristina-david,
peterschrammel,
pkesseli and
thk123
as code owners
smowton
force-pushed
the
smowton/feature/java-record-getstatic-source-locations
branch
from
35e1803 to
e97ed5c
Compare
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: e97ed5c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/130069395
| symbol_expr->source_location().get_java_bytecode_index() == "0" && | ||
| symbol_expr->get_identifier() == | ||
| "java::ClassReadingStaticField.x") | ||
| found = true; |
There was a problem hiding this comment.
⛏️ multi line condition so please add braces around the body
|
|
||
| WHEN("Converting the method that reads said field") | ||
| { | ||
| const auto &method_symbol = |
There was a problem hiding this comment.
⛏️ if the symbol isn't found, using lookup_ref makes the output on CI not very clear, better to use lookup and then REQUIRE(method_symbol != nullptr)
This enables trace-source-location reports not to vary depending on whether static initializer calls were produced or not (at present the call would result in a statement at the getstatic location, while the variable read itself would disappear; a 'putstatic' instruction by contrast always generates an assignment and so is accounted for by a source location).
smowton
force-pushed
the
smowton/feature/java-record-getstatic-source-locations
branch
from
e97ed5c to
4c5ddc9
Compare
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 4c5ddc9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/130528948
Codecov Report
@@ Coverage Diff @@
## develop #5144 +/- ##
========================================
Coverage 67.07% 67.07%
========================================
Files 1149 1149
Lines 94030 94030
========================================
Hits 63075 63075
Misses 30955 30955
Continue to review full report at Codecov.
|
This enables trace-source-location reports not to vary depending on whether static initializer
calls were produced or not (at present the call would result in a statement at the getstatic
location, while the variable read itself would disappear; a 'putstatic' instruction by contrast
always generates an assignment and so is accounted for by a source location).